Expand schema.org metadata #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vkrause
commented
Mar 3, 2024
vkrause
commented
- Add type for the location property.
- Add location name and event description.
- Provide address as machine-readable parts rather than a single string.
- Add type for the location property. - Add location name and event description. - Provide address as machine-readable parts rather than a single string.
kdesysadmin
pushed a commit
to KDE/kitinerary
that referenced
this pull request
Mar 3, 2024
Similar to what we do for string-based address properties, move those to the geo property instead. Allows importing from osmcal.org for example (once thomersch/openstreetmap-calendar#158 is deployed there at least to fix the missing @type for the location property).
|
This looks great, thanks! I am away from keyboard for a few days, I set myself a reminder to review it next week |
kdesysadmin
pushed a commit
to KDE/kitinerary
that referenced
this pull request
Mar 5, 2024
Similar to what we do for string-based address properties, move those to the geo property instead. Allows importing from osmcal.org for example (once thomersch/openstreetmap-calendar#158 is deployed there at least to fix the missing @type for the location property). (cherry picked from commit 808d853)
|
LGTM, I just formatted the file so it's consistent. Merging & deploying now. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.